Repository navigation
fix(lab-ops-hub): keep the empty-query marker before the fragment (#654) - #663
Merged
Merged
Conversation
…the container validator (#654)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 3
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #654
Problem
PR #648 (#639) re-attached the empty
?/#markers as a suffix after everygeturl()rebuild. When the query is empty and the fragment is non-empty, the?therefore landed after the fragment:http://example.com/path?#fragcame back ashttp://example.com/path#frag?— a different URL (fragment corrupted tofrag?, empty query absent) than the Worker returns, on the plain, percent-decoded-host and canonical-IP return paths alike.Solution
_attach_empty_query_fragment_markers(rebuilt, source_url)helper: the empty-query marker is inserted before the#that introduces a non-empty fragment in the rebuilt URL; the empty-fragment marker (fragment empty by definition) remains a suffix.?#,?x#,#frag?notqueryand all other lab-ops-hub: container validator returns empty path, empty port and empty userinfo un-normalized — recorded URL differs from the Worker #639 cases are unchanged.geturl() + markers:_url_with_host,_normalize_validated_urland_url_with_encoded_components. The fetcher's_split_userinforebuild, which dropped the markers entirely, uses it too.Tests
test_returns_empty_query_marker_before_a_nonempty_fragment: the issue battery plus percent-decoded / IP / userinfo / encoded-fragment arms, lab-ops-hub: container validator returns empty path, empty port and empty userinfo un-normalized — recorded URL differs from the Worker #639 controls, a_split_userinfopin and a redirect-handler pin. Ablation exact: with onlyapp.pyreverted, only this test fails, with the exactpath#frag?divergence.?#fragspellings (Worker already returns them).?#frag,?#,?x#frag,#frag?notquery): zero differences in verdict or returned form.Single-repo: no
validate_crawl_url/validateCrawlUrlcopy in the opencode, openchamber or nix clones (git-grep clean).Need help on this PR? Tag
@codesmith-botwith what you need.